----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29278/#review69693 -----------------------------------------------------------
common/src/main/java/org/apache/drill/common/config/package-info.java <https://reviews.apache.org/r/29278/#comment114472> Added some more information about how config files are persisted and a referral to the class responsible for finding the files on the classpath/resolving configuration precedence. common/src/main/java/org/apache/drill/common/exceptions/package-info.java <https://reviews.apache.org/r/29278/#comment114414> Fair enough, for consistency I just documented it. common/src/main/java/org/apache/drill/common/exceptions/package-info.java <https://reviews.apache.org/r/29278/#comment114473> I just wanted ot be consistent and have everything documented. common/src/main/java/org/apache/drill/common/expression/package-info.java <https://reviews.apache.org/r/29278/#comment114415> added additional clarification common/src/main/java/org/apache/drill/common/expression/package-info.java <https://reviews.apache.org/r/29278/#comment114416> added additional clarificaion common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java <https://reviews.apache.org/r/29278/#comment114422> Added some information about where the visitors are used. common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java <https://reviews.apache.org/r/29278/#comment114424> Updated comments to clarify the relationship between format plugins and storage plugins. common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java <https://reviews.apache.org/r/29278/#comment114426> This actually isn't being used as the base class for anything. Opened a JIRA to review the current structure and removed the docs for now. https://issues.apache.org/jira/browse/DRILL-2076 exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java <https://reviews.apache.org/r/29278/#comment114463> Added curator to the comment. I don't really think we maintain much beside cluster membership using zookeeper. I think this is a reasonable descritpion for now. exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java <https://reviews.apache.org/r/29278/#comment114443> I have fixed the comment to include a link. I started writing a more complete intro for new developers, but it was getting a bit long without covering the breadth I wanted. I have opened a JIRA for better starting documentation for new developers here as well as on the Wiki. I would like to get this patch in sooner to encourge others to write docs with a consistent style and format, but I will be trying to fit in an improvement to this documentation soon. https://issues.apache.org/jira/browse/DRILL-2077 - Jason Altekruse On Jan. 15, 2015, 10:16 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29278/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 10:16 p.m.) > > > Review request for drill, Daniel Barclay and Jacques Nadeau. > > > Bugs: Drill-1904 > https://issues.apache.org/jira/browse/Drill-1904 > > > Repository: drill-git > > > Description > ------- > > Add package level documentation to the sources of Drill > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/config/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/exceptions/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java > 5f18aaf > > common/src/main/java/org/apache/drill/common/expression/fn/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/expression/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/expression/types/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/graph/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java > 936e4f2 > > common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java > 0704085 > common/src/main/java/org/apache/drill/common/logical/data/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/logical/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION > common/src/main/java/org/apache/drill/common/types/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/util/package-info.java > PRE-CREATION > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29278/diff/ > > > Testing > ------- > > Just comments, no code changes > > > Thanks, > > Jason Altekruse > >
