-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30405/#review70428
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
<https://reviews.apache.org/r/30405/#comment115606>

    I was a little bit confused when looking at the profile in the web ui. I 
originally thought the peak memory data was missing for a bunch of the 
profiles, but it it really just means that the value is less than 1 mb. It was 
a bit confusing.


- Steven Phillips


On Jan. 29, 2015, 7:34 a.m., Jacques Nadeau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30405/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 7:34 a.m.)
> 
> 
> Review request for drill, Jason Altekruse and Steven Phillips.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Enhance web ui to provide more information including hostname, memory 
> allocation and fragment status
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 
> dc47f4e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java 
> 4431235 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
>  e8cb4ba 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ProfileResources.java
>  58b3d4e 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ProfileWrapper.java
>  80c08d3 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/Comparators.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/Filters.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorPathBuilder.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
>  PRE-CREATION 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 
> b33042b 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/AbstractStatusReporter.java
>  c7ac311 
> 
> Diff: https://reviews.apache.org/r/30405/diff/
> 
> 
> Testing
> -------
> 
> manual verification of profile layout on test queries.
> 
> 
> Thanks,
> 
> Jacques Nadeau
> 
>

Reply via email to