> On Jan. 29, 2015, 5:32 p.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java, > > line 223 > > <https://reviews.apache.org/r/30404/diff/1/?file=839779#file839779line223> > > > > Isn't this redundant with what QueryManager has? QueryManager is a > > FragmentStatusListener, and it's statusUpdate() method maintains status for > > fragments via updateFragmentStatus(). It seems like all that is required is > > to ask for that status when you want it. > > Jacques Nadeau wrote: > Fragment status listener only reports status changes. This captures the > current stats without a status change. This allows the profile UI to provide > query stats for long running queries so people can see their query is > progressing even if it is not complete.
Yes, but the Fragment status listener I'm referring to records the statuses, so they should all already be there from all past changes -- it shouldn't be necessary to probe them all to find the current status, just ask for it from the fragment map in the QueryStatus/QueryManager. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30404/#review70304 ----------------------------------------------------------- On Jan. 28, 2015, 11:35 p.m., Jacques Nadeau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30404/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 11:35 p.m.) > > > Review request for drill, Chris Westin and Steven Phillips. > > > Repository: drill-git > > > Description > ------- > > Update Workmanager to report status of fragments back to Foreman so that > profiles show intermediate status. > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/work/StatusProvider.java > 9215f43 > exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java > 5bc3da1 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/AbstractStatusReporter.java > c7ac311 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > 9ffe643 > > Diff: https://reviews.apache.org/r/30404/diff/ > > > Testing > ------- > > Hand testing on long running queries to ensure query stats were updated > during query. > > > Thanks, > > Jacques Nadeau > >
