----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30622/#review71101 -----------------------------------------------------------
We should add documentation to the method that was used incorrectly. It was my mistake for not looking more carefully DrillbitContext, or thinking through the fact the the drillbit should not have knowledge of the individual query options. However as this interface is exposed at this level through a direct reference to drillbitcontext and I think it would be good to document its functionality and possibly open an enhancement request to review where the method is being used and remove the ability to access it from operators. - Jason Altekruse On Feb. 4, 2015, 4:48 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30622/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 4:48 p.m.) > > > Review request for drill, Jacques Nadeau and Jason Altekruse. > > > Bugs: DRILL-1953 > https://issues.apache.org/jira/browse/DRILL-1953 > > > Repository: drill-git > > > Description > ------- > > Setting *store.json.all_text_mode* on the *SESSION* level doesn't have any > effect on *JSONRecordReader* > > The same problem was found and fixed in *MongoRecordReader* > > > Diffs > ----- > > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java > 4b73600 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java > 0070d18 > > exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java > 449f091 > exec/java-exec/src/test/resources/jsoninput/big_numeric.json PRE-CREATION > > Diff: https://reviews.apache.org/r/30622/diff/ > > > Testing > ------- > > added new unit test to test the fix > all unit tests pass > both *Functional* and *TPCH SF100* tests pass > > > Thanks, > > abdelhakim deneche > >
