----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31099/#review72798 -----------------------------------------------------------
Ship it! Ship It! - Hanifi Gunes On Feb. 16, 2015, 10:38 p.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31099/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 10:38 p.m.) > > > Review request for drill, Hanifi Gunes, Mehant Baid, Norris Lee, and Xiao > Meng. > > > Repository: drill-git > > > Description > ------- > > The client lib has two error objects that are set for connection level and > query level errors respectively. The issue was that for query level errors > the connection level error was also being set (to the same object) and under > certain conditions could cause multiple delete of the error object. > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp 9ecee24 > contrib/native/client/src/clientlib/drillClientImpl.hpp bd33317 > contrib/native/client/src/clientlib/drillClientImpl.cpp 40bd81e > > Diff: https://reviews.apache.org/r/31099/diff/ > > > Testing > ------- > > Ran thru test queries on all platforms. Valgrind on Linux. > > > Thanks, > > Parth Chandra > >
