----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31107/#review73593 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java <https://reviews.apache.org/r/31107/#comment119992> You could use Thread.currentThread() once here, and then reuse. - Chris Westin On Feb. 20, 2015, 5:39 p.m., Yuliya Feldman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31107/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 5:39 p.m.) > > > Review request for drill, Chris Westin, Jacques Nadeau, Steven Phillips, and > Venki Korukanti. > > > Bugs: DRILL-2210 > https://issues.apache.org/jira/browse/DRILL-2210 > > > Repository: drill-git > > > Description > ------- > > In addition to description > > Fixed few classes that did not handle multithreading well > Added/Changed some Stats behavior to allow stats merge from multiple threads, > since again this class is not suitable to be used in multithreaded environment > Introduced new decorator class to handle multi thrteading (or not) to > minimize changes to ParitionSenderRootExec class > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorStats.java > 0e9da0e > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java > 7af7b65 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java > f09acaa > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/Partitioner.java > 5ed9c39 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerTemplate.java > 4292c09 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java > faa8546 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java > aa0a5ad > > Diff: https://reviews.apache.org/r/31107/diff/ > > > Testing > ------- > > Still need to provide Unit Tests. > > Functional tests are passing > > Performance tests were run and look promising for some queries > > > Thanks, > > Yuliya Feldman > >
