----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31399/ -----------------------------------------------------------
(Updated Feb. 25, 2015, 6:28 p.m.) Review request for drill, Aditya Kishore and Jason Altekruse. Changes ------- Moved Mockito's dependency element to root pom.xml; removed now-unneeded JUnit, JMockit additons to exec/java-exec/pom.xml. Repository: drill-git Description (updated) ------- Main change: In exec/java-exec/pom.xml, suppressed Paranamer's transitive dependency on Mockito and the Hamcrest files bundled in it, and put JUnit and thereby Hamcrest on classpath before Mockito. NOTE: Please review placement (and details) of the added <dependency.../> elements. The current placement seems to work, but probably doesn't follow our intended Maven patterns. Other change: Added tests to detect regression (or confirm other solutions to problem). Diffs (updated) ----- common/src/test/java/org/apache/drill/test/Drill2130CommonHamcrestConfigurationTest.java PRE-CREATION contrib/storage-hbase/src/test/java/org/apache/drill/hbase/test/Drill2130StorageHBaseHamcrestConfigurationTest.java PRE-CREATION contrib/storage-hive/core/src/test/java/org/apache/drill/exec/test/Drill2130StorageHiveCoreHamcrestConfigurationTest.java PRE-CREATION exec/interpreter/src/test/java/org/apache/drill/exec/expr/test/Drill2130InterpreterHamcrestConfigurationTest.java PRE-CREATION exec/java-exec/pom.xml 06f60fb exec/java-exec/src/test/java/org/apache/drill/exec/test/Drill2130JavaExecHamcrestConfigurationTest.java PRE-CREATION exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2130JavaJdbcHamcrestConfigurationTest.java PRE-CREATION pom.xml dc1448c Diff: https://reviews.apache.org/r/31399/diff/ Testing ------- Ran new and existing tests. Thanks, Daniel Barclay
