> On Feb. 25, 2015, 8:05 p.m., Daniel Barclay wrote: > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java, line 219 > > <https://reviews.apache.org/r/31419/diff/1/?file=875900#file875900line219> > > > > Should/can this be a call to releaseIfFirst() rather than directly > > calling latch.countDown()?
releaseIfFirst will set receivedMessage to true which may not be correct. - Parth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31419/#review74081 ----------------------------------------------------------- On Feb. 25, 2015, 6:38 p.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31419/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 6:38 p.m.) > > > Review request for drill, Daniel Barclay, Hanifi Gunes, and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > Sqlline hangs when you try to cancel the query before the first result set > has been returned. > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 88a6c6d > > Diff: https://reviews.apache.org/r/31419/diff/ > > > Testing > ------- > > Tested with a query that takes a long time to return the first result set. > Ctrl-C to exit the query. This fix simply addresses the hang. It does not fix > Avatica to display cancellation in a nicer manner. Also, have not verified > that the query cancellation occurs on the drillbit in all cases (waiting for > DRILL-2245) > > > Thanks, > > Parth Chandra > >
