-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31436/
-----------------------------------------------------------
Review request for drill and Jacques Nadeau.
Bugs: DRILL-2245
https://issues.apache.org/jira/browse/DRILL-2245
Repository: drill-git
Description
-------
DRILL-2245-hygiene: General code cleanup encountered while working on the core
of this commit. This includes
- making members final whenever possible
- making members private whenever possible
- making loggers private
- removing unused imports
- removing unused private functions
- removing unused public functions
- removing unused local variables
- removing unused private members
- deleting unused files
- cleaning up formatting
- adding spaces before braces in conditionals and loop bodies
- breaking up overly long lines
- removing extra blank lines
While I tried to keep this clean, this commit may have minor dependencies on
DRILL-2245-core that I missed. The intention is just to break this up for
review purposes. Either both commits should be applied, or neither.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java
e413921
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java
c881432
exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java
5288f5d
exec/java-exec/src/main/java/org/apache/drill/exec/opt/IdentityOptimizer.java
979c5e2
exec/java-exec/src/main/java/org/apache/drill/exec/opt/Optimizer.java 34d0622
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
412da85
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/RootExec.java
a644c34
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java
7af7b65
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java
22fa047
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java
352e7ae
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/producer/ProducerConsumerBatch.java
4c9b33b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/Fragment.java
ac63bde
exec/java-exec/src/main/java/org/apache/drill/exec/record/MaterializedField.java
ef53d2a
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
f358097
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java
c00df4e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/NamedThreadFactory.java
2b49579
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java
f214c4d
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java
3a139f8
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcBus.java 96c9911
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/Controller.java
7f84a2b
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java
f8f6fd7
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java
197996d
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataResponseHandlerImpl.java
1fcb3e9
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java
5aa4aa6
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java
4e7fc92
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java
dffb9a1
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
ff6e13c
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/local/FilePStore.java
baa998d
exec/java-exec/src/main/java/org/apache/drill/exec/work/QueryWorkUnit.java
9743d6e
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/SpoolingRawBatchBuffer.java
6ee93ab
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.java
895918c
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/DrillbitStatusListener.java
ca52f0c
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/SimpleRootExec.java
0277876
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java b88d880
Diff: https://reviews.apache.org/r/31436/diff/
Testing
-------
mvn install
Functional - Passing - New
Advanced - TPCH SF100 - Parquet
Thanks,
Chris Westin
