----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29666/#review74686 -----------------------------------------------------------
Ship it! exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleRepeatedFunctions.java <https://reviews.apache.org/r/29666/#comment121356> I think it would be better if you use matches() instead of find(). Since you are invoking reset() above it will get the same result however invoking matches() explicitly states the intention of looking for the pattern in the entire string input. Looks ok, just one very minor comment. - Mehant Baid On Feb. 19, 2015, 8:17 p.m., Venkata krishnan Sowrirajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29666/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 8:17 p.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > Support for wildcards with in repeated_contains() is implemented similar to > MS SQL contains(). MS SQL contains() documentation > http://msdn.microsoft.com/en-us/library/ms187787.aspx > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleRepeatedFunctions.java > f7f0e91 > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewSimpleRepeatedFunctions.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29666/diff/ > > > Testing > ------- > > > Thanks, > > Venkata krishnan Sowrirajan > >
