----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31651/#review74883 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java <https://reviews.apache.org/r/31651/#comment121704> Is it possible to store the reference to FileSplit and create the info string only when an error occurs (inside the catch block)? exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java <https://reviews.apache.org/r/31651/#comment121705> This seems like not needed because we have already initialized above. exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java <https://reviews.apache.org/r/31651/#comment121706> Lets make this generic Exception. exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java <https://reviews.apache.org/r/31651/#comment121707> recordCount here refers to the number of records filled in current batch and not the current record position in RecordReader. May be we need to maintain a global count in member variable or get current position through RecordReader.getPos()? - Venki Korukanti On March 3, 2015, 12:53 a.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31651/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 12:53 a.m.) > > > Review request for drill and Venki Korukanti. > > > Repository: drill-git > > > Description > ------- > > Adding file split information to logs > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java > e413921 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java > 7c1f888 > > Diff: https://reviews.apache.org/r/31651/diff/ > > > Testing > ------- > > > Thanks, > > Sudheesh Katkam > >
