----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31748/#review75511 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java <https://reviews.apache.org/r/31748/#comment122648> can you please add some comments on the logic here? exec/java-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java <https://reviews.apache.org/r/31748/#comment122647> Let's clear and append rather than recreating. Also, use append to add \n rather than doing + concatenation. - Jacques Nadeau On March 4, 2015, 11:54 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31748/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 11:54 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Repository: drill-git > > > Description > ------- > > Gather messages while unwrapping an exception > > (+ color to sqlline in default mode) > > > Diffs > ----- > > distribution/src/resources/sqlline 0852fba > exec/java-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java > 0773d6c > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 378e81a > > Diff: https://reviews.apache.org/r/31748/diff/ > > > Testing > ------- > > > Thanks, > > Sudheesh Katkam > >
