> On March 6, 2015, 9:48 p.m., Mehant Baid wrote: > > changes look fine to me. Jinfeng could you review the changes to the class > > InterpreterEvaluator
Mehant noticed one issue in the InterpreterEvaluator already, where we unneccesarily allocate a new buffer for each literal on each evaluation on one record. I have added a new comment to the JIRA I created to track optimizations once we decide we need to improve performance of interpreting more than a few evaluations at a time. https://issues.apache.org/jira/browse/DRILL-2395?focusedCommentId=14350992&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14350992 - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30754/#review75551 ----------------------------------------------------------- On March 4, 2015, 11:52 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30754/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 11:52 p.m.) > > > Review request for drill, Aman Sinha, Jacques Nadeau, Jinfeng Ni, Mehant > Baid, and Parth Chandra. > > > Bugs: DRILL-2143 > https://issues.apache.org/jira/browse/DRILL-2143 > > > Repository: drill-git > > > Description > ------- > > This patch fixes the breakage of removing the record batch from the setup > method in the DrillFunc interface. It adds an injectable type to bring back > the date functions and make the interpreted expression evaluation work with > the new interface. > > > Diffs > ----- > > > exec/interpreter/src/test/java/org/apache/drill/exec/expr/ExpressionInterpreterTest.java > a94ef94 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java > 279c428 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionConverter.java > 0127e6e > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java > cc4be89 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java > a3bc1de > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/DrillSimpleFuncInterpreter.java > e3696f0 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java > 0fe36cb > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterGenerator.java > 6cede33 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/ValueHolder.java > 5c2adc6 > exec/java-exec/src/main/java/org/apache/drill/exec/expr/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java > e413921 > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryDateTimeInfo.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/ops/UdfUtilities.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30754/diff/ > > > Testing > ------- > > Almost all cluster tests are passing, recieved some failures that seem > unrelated and unlikely cased by the changes, but are not reported as expected > failures currently. Still need to run full unit tests again with these most > recent changes. > > > Thanks, > > Jason Altekruse > >
