----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31871/#review75973 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java <https://reviews.apache.org/r/31871/#comment123329> This should be AutoCloseable, not Closeable. Note that close() throws Exception then. exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java <https://reviews.apache.org/r/31871/#comment123330> Please document what the units for these are. Bytes? KB? MB? GB? exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java <https://reviews.apache.org/r/31871/#comment123337> Just an FYI - https://issues.apache.org/jira/browse/DRILL-2421 exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java <https://reviews.apache.org/r/31871/#comment123338> Please add this comment: // TODO(DRILL-1942) the new allocator has this capability built-in, so this can be removed once that is available exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java <https://reviews.apache.org/r/31871/#comment123339> Does getAllocator() really need to be public? exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java <https://reviews.apache.org/r/31871/#comment123340> throws Exception, since it's AutoCloseable. exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java <https://reviews.apache.org/r/31871/#comment123341> Please add this comment: // TODO(DRILL-1942) the new allocator has this capability built-in, so this can be removed once that is available - Chris Westin On March 9, 2015, 3:07 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31871/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 3:07 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-2406 > https://issues.apache.org/jira/browse/DRILL-2406 > > > Repository: drill-git > > > Description > ------- > > To enable planning rules to take advantage of constant expressions in > queries, or to allow them to run queries against small datasets, such as > partition information we need to e able to evaluate expressions at planning > time. Expression evaluation in the regular expecuation path is relatively > expensive, as it invovles java code generation, compilation and JITing > expression trees. An interpreted expression system was added recently to > allow evaluating an expression without generating java code at runtime. This > patch exposes that work (after some refactorings in 2143 and the first part > of 2406) to the planning context for use in optimizer rules. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java > 00aaec6 > > exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java > 2a28bcb > exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java > aa1dffd > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java > c881432 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java > 93fff35 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java > 907fcb1 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java > 6b54c43 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 409450f > > Diff: https://reviews.apache.org/r/31871/diff/ > > > Testing > ------- > > Cluster tests completed, waiting on unit tests. > > > Thanks, > > Jason Altekruse > >
