----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31995/ -----------------------------------------------------------
Review request for drill and Parth Chandra. Repository: drill-git Description ------- - Created basic test for DATA_TYPE and TYPE_NAME. - Fixed DATA_TYPE: Added mapping from type name/descriptor strings from INFORMATION_SCHEMA.COLUMNS.DATA_TYPE to java.sql.Types.* integer type codes for DatabaseMetaData.getColumns's DATA_TYPE. - Fixed TYPE_NAME: Added TYPE_NAME returning type name/descriptor strings from INFORMATION_SCHEMA.COLUMNS.DATA_TYPE - Added FIXMEs for some missing/misnamed/wrong fields. (See DRILL-2420.) NOTE: There are a number of unknowns noted in TODO comments. Diffs ----- exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 127751d exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsBugsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/31995/diff/ Testing ------- Ran new and existing tests. Thanks, Daniel Barclay
