> On March 16, 2015, 7:58 p.m., Jinfeng Ni wrote: > > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java, line > > 44 > > <https://reviews.apache.org/r/32089/diff/2/?file=896260#file896260line44> > > > > I understand these testcase should use "unOrdered()", in stead of > > "ordered(). But why do you change in this patch? Is it because you run into > > testcase failure with the original "ordered()", once you change > > ProjectRecordBatch? If so, then, we need understand why the testcase > > previously is successful with "ordered", and now fails with "ordered" with > > your code change in ProjectRecordBatch.
Oh...oh... Actually, either worked just fine. I made the change simply because it is not theoretically correct. - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32089/#review76631 ----------------------------------------------------------- On March 16, 2015, 7:45 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32089/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 7:45 p.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-2311 > https://issues.apache.org/jira/browse/DRILL-2311 > > > Repository: drill-git > > > Description > ------- > > In ProjectRecordBatch, ensure the output columns are unique. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java > 8f7812f > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 8ae0ae4 > > Diff: https://reviews.apache.org/r/32089/diff/ > > > Testing > ------- > > Unit tests, all QA tests > > > Thanks, > > Sean Hsuan-Yi Chu > >
