----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32082/#review76849 -----------------------------------------------------------
This is a significant fix. Can you add a unit test for this? - Parth Chandra On March 15, 2015, 9:11 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32082/ > ----------------------------------------------------------- > > (Updated March 15, 2015, 9:11 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > Fixed generated isNull methods which always returned false, even for > Nullable... versions of SqlAccessor. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/SqlAccessors.java b569185 > > Diff: https://reviews.apache.org/r/32082/diff/ > > > Testing > ------- > > Ran new tests for JDBC metadata fixes (DRILL-2420--related) and existing > tests. > > > Thanks, > > Daniel Barclay > >
