-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32418/
-----------------------------------------------------------
Review request for drill and Jason Altekruse.
Bugs: DRILL-1255
https://issues.apache.org/jira/browse/DRILL-1255
Repository: drill-git
Description
-------
Adding a system option `store.json.all_numerals_as_double_mode` for integers in
JSON to be read as Double. This is to accomodate such schema changes across
records in a JSON file.
Diffs
-----
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
15ef197
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java cd0a0a2
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/JsonConvertFrom.java
c828cf4
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
608fac7
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
c343177
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
cc5c8af
Diff: https://reviews.apache.org/r/32418/diff/
Testing
-------
Unit Tests
Precommit Tests (Passing tests: 1906, Execution Failures: 0,
VerificationFailures: 28 (expected - Partition Pruning), Timeouts: 0 )
TPCH SF 100 (Passing tests: 21, Execution Failures: 0, VerificationFailures: 2
(query1, query10)
Tests on the functionality - able to read JSON files containing integer to
double schema changes across records, after the option has been set (in both
embedded and cluster mode).
Thanks,
Abhishek Girish
