----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32455/#review77814 -----------------------------------------------------------
Ship it! Looks good. Nice work on the unit tests! - Parth Chandra On March 25, 2015, 4:56 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32455/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 4:56 a.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > - Added test DatabaseMetaDataGetColumnsTest. > - (Renamed Drill2128GetColumnsBugsTest to > Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.) > - Fixed/implemented various columns: > - Added COLUMN_SIZE (big CASE expression handling lots of cases). > - Fixed DECIMAL_DIGITS. > - Fixed NUM_PREC_RADIX. > - ~Fixed REMARKS ('' -> NULL). > - ~Fixed COLUMN_DEF ('' -> NULL). > - Fixed CHARACTER_OCTET_LENGTH. > - Fixed ORDINAL_POSITION. > - Fixed SCOPE_CATALOG, SCOPE_SCHEMA, SCOPE_TABLE, > - Fixed SOURCE_DATA_TYPE. > - Note: INTERVAL types have only *interim* implementations. > (INFORMATION_SCHEMA.COLUMNS fixes are needed for completion.) > - Added canonical data type name strings in DATA_TYPE -> TYPE_NAME CASE > expression (for robustness for expected upcoming INFORMATION_SCHEMA.COLUMNS > standard-compliance bug fixing). > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 99e0d22 > > exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java > PRE-CREATION > > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsBugsTest.java > 0a9104b > > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32455/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Barclay > >
