----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32327/#review77309 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java <https://reviews.apache.org/r/32327/#comment125221> Is the default value validated somewhere else? exec/java-exec/src/main/java/org/apache/drill/exec/testing/SimulatedExceptions.java <https://reviews.apache.org/r/32327/#comment125225> Is there any way to check if requestedPort was actually specified (if requestedAddress is non-null), and isn't just defaulting to zero? exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java <https://reviews.apache.org/r/32327/#comment126287> capture .injections[0] in a local and reuse it. exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java <https://reviews.apache.org/r/32327/#comment126295> Do we know that there's only one drillbit running for this test, or should we just make the test injections here global? exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java <https://reviews.apache.org/r/32327/#comment126296> Capture zkHelper.getConfig() and reuse it. - Chris Westin On March 20, 2015, 1:20 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32327/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 1:20 p.m.) > > > Review request for drill and Chris Westin. > > > Repository: drill-git > > > Description > ------- > > [DRILL-2437](https://issues.apache.org/jira/browse/DRILL-2437): Moved > SimulatedExceptions to UserSession > > + [DRILL-2382](https://issues.apache.org/jira/browse/DRILL-2382): Added > address and port to InjectionOption to specify drillbit > + JSONStringValidator to TypeValidators > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > cd0a0a2 > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java > efb0cdf > > exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java > dbf3c74 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java > b9721cc > > exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExceptionInjector.java > 54bc351 > > exec/java-exec/src/main/java/org/apache/drill/exec/testing/SimulatedExceptions.java > 0292c08 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > bfb6de8 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java > 9bc0552 > > exec/java-exec/src/test/java/org/apache/drill/exec/testing/ExceptionInjectionUtil.java > bf93dee > > exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java > d0c0279 > > Diff: https://reviews.apache.org/r/32327/diff/ > > > Testing > ------- > > Added test case. > > Passes all other tests, and builds. > > > Thanks, > > Sudheesh Katkam > >
