----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32523/#review78132 -----------------------------------------------------------
Ship it! Let's not worry about partial drop. Otherwise, lgtm. +1 - Jacques Nadeau On March 26, 2015, 3:49 a.m., Aman Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32523/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 3:49 a.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-2568 > https://issues.apache.org/jira/browse/DRILL-2568 > > > Repository: drill-git > > > Description > ------- > > Drop the filter plan node if all conjuncts in the filter have been pushed as > part of partition pruning, except for the situation where the new set of > files is empty - we add a single file in that case, so the Filter is > preserved in that case. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java > b8c9ebf > exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestPrune.java > d15555e > > Diff: https://reviews.apache.org/r/32523/diff/ > > > Testing > ------- > > Manual inspection of Explain plans for several types of queries. Running > regression tests.. > > > Thanks, > > Aman Sinha > >
