> On March 30, 2015, 4:35 p.m., Jacques Nadeau wrote: > > Can you please add a couple test cases specifically focused on confirming > > that the views show up in show tables and information schema?
I didn't add new tests because we already have tests TestViews.testInfoSchemaWithView and TestViews.testInfoSchemaWithHiveView which test views show up in "SHOW TABLES" and InfoSchema. These tests are passing. > On March 30, 2015, 4:35 p.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillType.java, > > line 47 > > <https://reviews.apache.org/r/32165/diff/1/?file=897856#file897856line47> > > > > Will this work on Windows? > > Jason Altekruse wrote: > I remember reading at some point that Java does some work to try to make > any system specific paths (hard coded with either '/' or '\') work on the > opposite platform. As the parent dir will contain separators itself, I assume > this would create a path with mixed separators. I don't know if Java is nice > enough to automatically interpret something like > C:\Users\Documets\data/datamyfile.jason correctly. It is fixable with just > using File.separator instead of a hard coded "/". > http://stackoverflow.com/questions/2417485/file-separator-vs-slash-in-paths Updated to use constructor Path(Path parent, Path child). This should add the correct directory separator. - Venki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32165/#review76754 ----------------------------------------------------------- On March 17, 2015, 5:56 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32165/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 5:56 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Repository: drill-git > > > Description > ------- > > Please see DRILL-1833 for details. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillFile.java > 6a5934b > > exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillType.java > 74b71e7 > > exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillUtil.java > cef4359 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java > 7a1f61e > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java > 7c8d9b3 > > Diff: https://reviews.apache.org/r/32165/diff/ > > > Testing > ------- > > Existing tests have passed. > > > Thanks, > > Venki Korukanti > >
