----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32591/#review78299 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java <https://reviews.apache.org/r/32591/#comment126840> I think disabling this will cause certain valid explicit type casting to fail - for example if an integer column has values 1 and 0, then cast(col as boolean) should produce true and false. Can you test this with your changes ? - Aman Sinha On March 27, 2015, 9:44 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32591/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 9:44 p.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-2590 > https://issues.apache.org/jira/browse/DRILL-2590 > > > Repository: drill-git > > > Description > ------- > > DRILL-2590: In implicit casting rule, make boolean to be implicitly castable > from boolean only > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java > 8fc6612 > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 520c204 > exec/java-exec/src/test/resources/store/json/booleanData.json PRE-CREATION > exec/java-exec/src/test/resources/store/json/intData.json PRE-CREATION > > Diff: https://reviews.apache.org/r/32591/diff/ > > > Testing > ------- > > QA, unit tests > > > Thanks, > > Sean Hsuan-Yi Chu > >
