> On March 31, 2015, 9:16 p.m., Jinfeng Ni wrote: > > Overall, looks good to me. Just two minor comments.
https://issues.apache.org/jira/browse/DRILL-2633 > On March 31, 2015, 9:16 p.m., Jinfeng Ni wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java, > > line 59 > > <https://reviews.apache.org/r/32701/diff/1/?file=911426#file911426line59> > > > > Here, the name of "getVisitor" is kind of misleading. We are actually > > creating a new instance of the visitor, each time when call this method. > > So, createVisitor or similar would be more appropriate. Renaming was done. Fixed! > On March 31, 2015, 9:16 p.m., Jinfeng Ni wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, > > line 57 > > <https://reviews.apache.org/r/32701/diff/1/?file=911428#file911428line57> > > > > "getVisitor" -- Similar as the above comment. Renaming was done. Fixed! - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32701/#review78402 ----------------------------------------------------------- On March 31, 2015, 8:58 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32701/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 8:58 p.m.) > > > Review request for drill and Jinfeng Ni. > > > Bugs: DRILL-2633 > https://issues.apache.org/jira/browse/DRILL-2633 > > > Repository: drill-git > > > Description > ------- > > The visitors PreProcessLogicalRel and UnsupportedOperatorsVisitor are made as > instances (non-static) > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java > 9e76611 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java > e908538 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > 46fb925 > > Diff: https://reviews.apache.org/r/32701/diff/ > > > Testing > ------- > > QA, unit all passed > > > Thanks, > > Sean Hsuan-Yi Chu > >
