[
https://issues.apache.org/jira/browse/DRILL-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Westin resolved DRILL-1909.
---------------------------------
Resolution: Duplicate
Fix Version/s: (was: 0.9.0)
Duplicates DRILL-2574, which went into 0.8 at commit
910e278ed3ee84db17de9e98739422d4ef86f124 . That fix originally tried to
synchronized increment() and decrement(), but this caused a hang when an RPC
thread tried to call decrement() when another thread was already in
waitForSendToComplete(). The current version
(https://github.com/apache/drill/commit/910e278ed3ee84db17de9e98739422d4ef86f124)
at least avoids the lost updates that were possible before, when batchesSent
was set to zero after waiting (batchesSent could have been incremented in the
meantime, causing a lost update). If there was another problem besides that,
please reopen and describe it here in more detail.
> Fix SendingAccountor thread safety
> ----------------------------------
>
> Key: DRILL-1909
> URL: https://issues.apache.org/jira/browse/DRILL-1909
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Reporter: Daniel Barclay (Drill)
> Assignee: Jacques Nadeau
> Priority: Minor
> Attachments: DRILL-1909.1.patch
>
>
> SendingAccountor's increment() method is not synchronized, but both it and
> (already synchronized) method waitForSendComplete() both modify the same
> variable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
