-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32707/#review78634
-----------------------------------------------------------



exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestBaseViewSupport.java
<https://reviews.apache.org/r/32707/#comment127548>

    We should make this non-static and use the actual test class name with 
this.class.getSimpleName(). With the unit tests (across test classes) being run 
conurrently we will risk them still having colliding names. I think we can 
safely remove the random number in this case as well.


- Jason Altekruse


On April 1, 2015, 12:15 a.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32707/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 12:15 a.m.)
> 
> 
> Review request for drill.
> 
> 
> Bugs: DRILL-2640
>     https://issues.apache.org/jira/browse/DRILL-2640
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Please see DRILL-2640 for details.
> 
> 
> Diffs
> -----
> 
>   
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/sql/hive/TestViewSupportOnHiveTables.java
>  PRE-CREATION 
>   
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestBaseViewSupport.java
>  PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 
> 3b55b99 
>   exec/java-exec/src/test/resources/nation/nation.tbl PRE-CREATION 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 3fe8e2f 
>   exec/jdbc/src/test/resources/nation/nation.tbl ed3fd5b 
> 
> Diff: https://reviews.apache.org/r/32707/diff/
> 
> 
> Testing
> -------
> 
> Unittests pass. Changes are only to test components.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>

Reply via email to