----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32593/#review78727 -----------------------------------------------------------
Ship it! Ship It! - Parth Chandra On March 31, 2015, 9:32 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32593/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 9:32 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2579 > https://issues.apache.org/jira/browse/DRILL-2579 > > > Repository: drill-git > > > Description > ------- > > Nulled out member to avoid re-using closed Connection. > > > Diffs > ----- > > > exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java > 88fb4c6 > > Diff: https://reviews.apache.org/r/32593/diff/ > > > Testing > ------- > > Manual: Broke a JDBC JUnit test, ran it, saw hang, applied fix line, ran > again, saw hang gone. > > Ran existing tests. > > > Thanks, > > Daniel Barclay > >
