-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32800/#review78765
-----------------------------------------------------------
Can you check this patch on Mac/Linux. On the Mac I get a compilation error:
/drill/contrib/native/client/src/clientlib/drillClient.cpp:310:23: error:
non-const lvalue reference to type 'basic_string<[3 * ...]>' cannot bind to a
temporary of type 'basic_string<[3 * ...]>'
props.setProperty(std::string(USERPROP_SCHEMA), schema);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from
/Users/pchandra/work/drill/contrib/native/client/src/clientlib/drillClient.cpp:22:
/drill/contrib/native/client/src/clientlib/../include/drill/drillClient.hpp:144:40:
note: passing argument to parameter 'propName' here
void setProperty( std::string& propName, std::string& propValue){
- Parth Chandra
On April 2, 2015, 11:46 p.m., Norris Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32800/
> -----------------------------------------------------------
>
> (Updated April 2, 2015, 11:46 p.m.)
>
>
> Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.
>
>
> Bugs: DRILL-2671
> https://issues.apache.org/jira/browse/DRILL-2671
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DrillUserProperty::setProperty is taking std::string as parameters. Memory
> gets allocated in the client yet Drill Client tries to clean it up.
>
>
> Diffs
> -----
>
> contrib/native/client/example/querySubmitter.cpp bef64bf
> contrib/native/client/src/clientlib/drillClient.cpp 90aa555
> contrib/native/client/src/include/drill/drillClient.hpp 9289df3
>
> Diff: https://reviews.apache.org/r/32800/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Norris Lee
>
>
