> On April 3, 2015, 5:56 p.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java, > > line 137 > > <https://reviews.apache.org/r/32799/diff/1/?file=914237#file914237line137> > > > > Is it necessary to create a separate getSqlHandler method ? I think you > > could modify the existing DrillSqlCall.getSqlHandler() to accept a > > textPlan...the advantage of doing that would be that it would work even for > > other CREATE statements such as CREATE VIEW etc, in addition to CREATE > > TABLE.
For this one, we probably have to keep getSqlHandler(config) because lots of subclasses override this method; Any change on it could propagate a lot then. - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32799/#review78810 ----------------------------------------------------------- On April 3, 2015, 8:07 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32799/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 8:07 p.m.) > > > Review request for drill, Aman Sinha and Jason Altekruse. > > > Bugs: DRILL-2596 > https://issues.apache.org/jira/browse/DRILL-2596 > > > Repository: drill-git > > > Description > ------- > > Let the plan for CTAS queries be saved and shown in WebUI > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java > 710418b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java > 111222e > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java > a6bd8b7 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java > 5e3c215 > > Diff: https://reviews.apache.org/r/32799/diff/ > > > Testing > ------- > > QA, unit tests > > > Thanks, > > Sean Hsuan-Yi Chu > >
