----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32947/#review79486 -----------------------------------------------------------
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java <https://reviews.apache.org/r/32947/#comment128895> You should name the columns explicitly in the subquery instead of relying on EXPR$0 which is a planner generated name and could change in the future. - Aman Sinha On April 8, 2015, 12:34 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32947/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 12:34 a.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-2717 > https://issues.apache.org/jira/browse/DRILL-2717 > > > Repository: drill-git > > > Description > ------- > > The upstream message returned by Union-All (when innerNext is called on > Union-All) is corrected > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java > 61de3a4 > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013 > > Diff: https://reviews.apache.org/r/32947/diff/ > > > Testing > ------- > > QA, unit > > > Thanks, > > Sean Hsuan-Yi Chu > >
