----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33006/#review79820 -----------------------------------------------------------
exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java <https://reviews.apache.org/r/33006/#comment129418> Can you put that "////////" back? (It separates the simpler types (creatable via CAST in the test's created view) from the complex types.) - Daniel Barclay On April 10, 2015, 5:51 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33006/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 5:51 p.m.) > > > Review request for drill, Daniel Barclay, Hanifi Gunes, and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > See DRILL-2641 for details. > > Also: > - Update the tests to use the new test framework > - Remove duplicate tests (TestHiveScalarUDFs.java) > - Remove JDBC module dependency on Hive storage plugin module. > - Disabled few tests in jdbc.DatabaseMetaDataGetColumnsTest which were using > Hive table for certails column types such as array, map, struct and union > which are not possible as input types for filesystem tables. This test was > blocking from removing exec/jdbc module dependency on contrib/storage-hive > module. > > > Diffs > ----- > > contrib/storage-hive/core/src/main/resources/bootstrap-storage-plugins.json > 5c7174e > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java > a76128f > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestInfoSchemaOnHiveStorage.java > PRE-CREATION > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java > 657da61 > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java > PRE-CREATION > exec/jdbc/pom.xml 2385d74 > > exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java > 1a7b63d > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveScalarUDFs.java > 2c1738c > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestHiveStorage.java > 2c41e12 > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java > 3534f35 > exec/jdbc/src/test/resources/bootstrap-storage-plugins.json 548ec3d > > Diff: https://reviews.apache.org/r/33006/diff/ > > > Testing > ------- > > > Thanks, > > Venki Korukanti > >
