----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33043/#review79891 -----------------------------------------------------------
Ship it! Ship It! - Parth Chandra On April 12, 2015, 2:21 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33043/ > ----------------------------------------------------------- > > (Updated April 12, 2015, 2:21 a.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2613 > https://issues.apache.org/jira/browse/DRILL-2613 > > > Repository: drill-git > > > Description > ------- > > Code "hygiene": > - Renamed parameter index to rowOffset, and documented it, in SqlAccessor. > - Renamed index to rowOffset in AbstractSqlAccessor and BoundCheckingAccessor > too. > - Fixed a cast to DrillResultSet to be a ResultSet.unwrap(...) call. > > Preparation: Split DrillResultSet into interface vs. implementation: > - Moved old implementation class org.apache.drill.jdbc.DrillResultSet > to new implementation class > org.apache.drill.jdbc.impl.DrillResultSetImpl. > - Created new interface org.apache.drill.jdbc.DrillResultSet, > declaring method getQueryId(...). > - Relatedly, in nearby JDBC code: > - Renamed various references. > - Added some "public" qualifiers. Most are only for the interim until > DRILL-2089 (moving other implementation classes from org.apache.drill.jdbc > to org.apache.drill.jdbc.impl) is completed sufficiently. (See marking > with "DRILL-2089".)n > - (Files: old DrillResultSet, DrillResultSetImpl, new DrillResultSet; > DrillConnectionImpl, DrillCursor, DrillJdbc41Factory, MetaImpl; > JdbcTestQueryBase.) > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java > 1605c7d > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java > c8d6cc7 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java > adee171 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java > 6007bf4 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java > ccf2658 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc > exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java > PRE-CREATION > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java > PRE-CREATION > > exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java > PRE-CREATION > > exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33043/diff/ > > > Testing > ------- > > Ran existing tests. > > > Thanks, > > Daniel Barclay > >
