----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30106/#review79966 -----------------------------------------------------------
Ship it! Ship It! - Jason Altekruse On Feb. 11, 2015, 6:05 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30106/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 6:05 p.m.) > > > Review request for drill. > > > Bugs: DRILL-1970 > https://issues.apache.org/jira/browse/DRILL-1970 > > > Repository: drill-git > > > Description > ------- > > Until Drill can support querying of Hive Views, hive views metadata must not > be visible upon issuing the "show tables" command. > > > Diffs > ----- > > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java > 023517b > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java > 0758791 > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java > c52eafd > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 28fa4a7 > > Diff: https://reviews.apache.org/r/30106/diff/ > > > Testing > ------- > > updated unit tests to make sure hive views are not visible when running SHOW > TABLES or SELECT * FROM INFORMATION_SCHEMA.VIEWS. > > local and functional tests are running fine, except for some functional tests > that are not related to this patch. I also manually tested "show tables" and > confirmed Hive Views are no longer visible. > > customer regression tests are also passing > > > Thanks, > > abdelhakim deneche > >
