----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33220/#review80220 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java <https://reviews.apache.org/r/33220/#comment130012> What is ValidationException? For "table not exists" type error, Calcite/Optiq will throw SqlValidatorException? Does it make sense to raise SqlValidatorException for "table with same name already exists" error? - Jinfeng Ni On April 15, 2015, 8:01 a.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33220/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 8:01 a.m.) > > > Review request for drill and Jinfeng Ni. > > > Repository: drill-git > > > Description > ------- > > See DRILL-2422 for details. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java > 300d65d > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java > 4347249 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java > 325f770 > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java > 578eace > > Diff: https://reviews.apache.org/r/33220/diff/ > > > Testing > ------- > > Added unittests for both CreateTable and CreateView > > > Thanks, > > Venki Korukanti > >
