----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33228/#review80221 -----------------------------------------------------------
Ship it! Ship It! - Mehant Baid On April 15, 2015, 4:29 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33228/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 4:29 p.m.) > > > Review request for drill and Mehant Baid. > > > Bugs: DRILL-2754 > https://issues.apache.org/jira/browse/DRILL-2754 > > > Repository: drill-git > > > Description > ------- > > Fix a small allocation error in repeated vectors, added unit test as well as > a utility method to concisely create lists and maps for speifying baseline > values of queries that return complex types. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java c7cf8e6 > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 6df5801 > exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java > f8db533 > > exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java > 3f69fd0 > exec/java-exec/src/test/resources/store/json/null_list.json PRE-CREATION > exec/java-exec/src/test/resources/store/json/null_list_v2.json PRE-CREATION > exec/java-exec/src/test/resources/store/json/null_list_v3.json PRE-CREATION > > Diff: https://reviews.apache.org/r/33228/diff/ > > > Testing > ------- > > Testing in progress > > > Thanks, > > Jason Altekruse > >
