----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33343/#review80650 -----------------------------------------------------------
Ship it! Ship It! - Aman Sinha On April 20, 2015, 4:55 a.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33343/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 4:55 a.m.) > > > Review request for drill and Aman Sinha. > > > Repository: drill-git > > > Description > ------- > > DRILL-2753 aims to remove the comparision function implementations that have > different data type inputs (Look at the JIRA for more details). As a result > we need to modify hash join and merge join so that when we have different > types in the join condition they can apply implicit casts to do the > comparison. We have resolved the issue of distribution (as part of > DRILL-2244) and so different data types with the same numeric value will be > correctly distributed to the same node. > > As part of this change we materialize the expression in the join condition, > check if the types are different and apply casts if necessary. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java > 9df67d8 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java > 7fa79a1 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java > 8fce52e > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java > 796f6fe > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestJoinAdvanced.java > PRE-CREATION > exec/java-exec/src/test/resources/jsoninput/implicit_cast_join_1.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/33343/diff/ > > > Testing > ------- > > Added unit tests plus ran existing tests with different data types in join > conditions. > > > Thanks, > > Mehant Baid > >
