----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33290/#review80901 -----------------------------------------------------------
Ship it! Ship It! - Parth Chandra On April 20, 2015, 3:03 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33290/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 3:03 a.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2782 > https://issues.apache.org/jira/browse/DRILL-2782 > > > Repository: drill-git > > > Description > ------- > > - Fixed/moved checkNotClosed to after constructor. > - Removed redundant "public"; "privatized" logger. > - Purged unused imports. > - A little commenting, editing, wrapping. > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java a52644d > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > 3fdbf84 > exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 78ca221 > > Diff: https://reviews.apache.org/r/33290/diff/ > > > Testing > ------- > > Ran existing tests; no new problems. > > > Thanks, > > Daniel Barclay > >
