> On Sept. 29, 2014, 8:17 a.m., Mehant Baid wrote: > > exec/java-exec/src/test/java/org/apache/drill/TestTestFramework.java, line > > 38 > > <https://reviews.apache.org/r/26088/diff/1/?file=706175#file706175line38> > > > > While comparing the results are we checking to see if the column names > > match? This is useful when we use column aliases.
fixed this to look for missing or extra columns. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26088/#review54758 ----------------------------------------------------------- On Nov. 19, 2014, 12:12 a.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26088/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:12 a.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > new unit test framework to ease the process of creating unit tests with full > result verification > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/types/Types.java 8ae3edd > exec/java-exec/src/main/resources/bootstrap-storage-plugins.json 4a20bea > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 18fe84e > exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java > PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java > 5768908 > exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java PRE-CREATION > exec/java-exec/src/test/java/org/apache/drill/TestTestFramework.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/HyperVectorValueIterator.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java > ac5673d > exec/java-exec/src/test/resources/sort/testSelectWithLimitOffset.tsv > PRE-CREATION > exec/java-exec/src/test/resources/store/json/json_simple_with_null.json > PRE-CREATION > exec/java-exec/src/test/resources/testframework/decimal_test.json > PRE-CREATION > exec/java-exec/src/test/resources/testframework/decimal_test.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/schema_change_int_to_string_non-matching.json > PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data.json > PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/small_test_data_extra.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/small_test_data_extra_col.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/small_test_data_reordered.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/small_test_data_reordered_non_match_extra.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/small_test_data_reordered_non_match_fewer.tsv > PRE-CREATION > exec/java-exec/src/test/resources/vector/complex/fn/nested-with-nulls.json > 7ce785c > pom.xml 26189fd > > Diff: https://reviews.apache.org/r/26088/diff/ > > > Testing > ------- > > Added both positive an negative unit test for varioud functionalities in the > unit test framework. All previous unit tests are passing. > > > Thanks, > > Jason Altekruse > >
