-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33345/
-----------------------------------------------------------

(Updated April 22, 2015, 6:57 p.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Changes
-------

Rebased on fresh master; attaching new patch.


Bugs: DRILL-2829
    https://issues.apache.org/jira/browse/DRILL-2829


Repository: drill-git


Description
-------

- Clarified column constant names.  Also grouped and ordered them.
- Added/applied constant for catalog name "DRILL".
- Fixed "implements ...Constants" old-Java hack (to static imports).
- Purged some unused imports.
- A little documentation, editing, TODOs.


Diffs (updated)
-----

  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java
 15721d5 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowSchemasHandler.java
 a037be3 
  
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java
 4ac81e9 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 
2d6ac4f 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaConstants.java
 8350d89 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilterBuilder.java
 ddbbe51 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java
 0a9c32c 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaTable.java
 0e9ca53 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/RecordGenerator.java
 772b9e4 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java 
f14fa7e 
  
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/SelectedTable.java
 088736b 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java 
9a5aa65 

Diff: https://reviews.apache.org/r/33345/diff/


Testing
-------

Ran tests.


Thanks,

Daniel Barclay

Reply via email to