----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33540/ -----------------------------------------------------------
Review request for drill and Mehant Baid. Repository: drill-git Description ------- Created a interface to allow clients to create either RexNode or LogicalExpression. Logic for generating the hash expression is one place now. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java 9df67d8 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashPrelUtil.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToMergeExchangePrel.java 7a0cbeb exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToRandomExchangePrel.java c08e6b6 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PrelUtil.java c8141cd exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnorderedDeMuxExchangePrel.java e04f6d0 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java d8311c7 exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java 2080fce Diff: https://reviews.apache.org/r/33540/diff/ Testing ------- Ran TCPH SF 100 with hash agg disabled. No verification issues reported. Thanks, Venki Korukanti
