----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33610/#review81877 -----------------------------------------------------------
Ship it! Ship It! - Hanifi Gunes On April 28, 2015, 1 a.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33610/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 1 a.m.) > > > Review request for drill, Hanifi Gunes and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > DRILL-2872: Result from json file returns data from repeated type fields as > "null" > > The isSet method for HolderReaderImpl(s) checks the isSet for the 'holder' > member. For repeated types, though, it needs to check the 'repeatedHolder' > member. > > > Diffs > ----- > > exec/java-exec/src/main/codegen/templates/HolderReaderImpl.java > 7d4ff318cde462bbf5c29e38d25f0ac15eac94f4 > > exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java > 933352340b8347b120cf9c3c8dbf8c2ccfcad0c6 > exec/java-exec/src/test/resources/DRILL-2872-result.json PRE-CREATION > exec/java-exec/src/test/resources/complex_student.json PRE-CREATION > > Diff: https://reviews.apache.org/r/33610/diff/ > > > Testing > ------- > > All regression and unit tests. Added new unit test for this case. > > > Thanks, > > Parth Chandra > >
