-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33652/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: drill-2884
https://issues.apache.org/jira/browse/drill-2884
Repository: drill-git
Description
-------
- Re-ordered UserResultsListener methods logically (chronologically).
(In UserResultsListener too.)
- Re-ordered some other ResultsListener methods more logically
(chronologically).
- Added ResultsListener logging (incoming and outgoing).
- Moved queryId down into ResultListener so ResultListener doesn't need to
reach up into DrillResultSetImpl; changed from inner to nested class.
- Renamed:
-- Fixed typo "resultslistener" -> "resultsListener"
-- MAX -> THROTTLING_QUERY_SIZE_THRESHOLD, queue -> batchQueue, ex ->
executionFailureException
- Added, purged some TODOs.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserResultsListener.java
e422a3f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 41b89ce
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java
484a5e5
Diff: https://reviews.apache.org/r/33652/diff/
Testing
-------
Ran regular tests.
Thanks,
Daniel Barclay