Dev./unit test TestPStoreProviders seems to be failing in master as
of:
commit c7cb36c8b45613bab299dfe6cafb36d4d2e00add
Date: Tue Apr 28 21:05:48 2015 -0700
DRILL-2896: Fix TestComplexTypeReader.testRepeatedJson
Maven's output says:
...
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 9.048 sec <<<
FAILURE! - in org.apache.drill.exec.store.sys.TestPStoreProviders
verifyZkStore(org.apache.drill.exec.store.sys.TestPStoreProviders) Time elapsed: 2.811
sec <<< FAILURE!
java.lang.AssertionError: null
at
org.apache.drill.exec.store.sys.PStoreTestUtil.test(PStoreTestUtil.java:66)
at
org.apache.drill.exec.store.sys.TestPStoreProviders.verifyZkStore(TestPStoreProviders.java:55)
...
Note that right before the code with the failing assertFalse, there is a
comment about waiting a second for things to complete--but no apparent
code that actually waits.
(Additionally, we should try to avoid arbitrary timed waits--they make
things less predictable and make debugging much more complicated.)
By the way, assertFalse (etc.) has an overloaded case that takes a string
to be printed out when the check fails. A string mentioning the error
condition would be significantly more helpful than just the "null" that
showed up above.
Daniel
--
Daniel Barclay
MapR Technologies
