----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33840/#review82587 -----------------------------------------------------------
Ship it! Looks good to me. Just have 2 minor comments. exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java <https://reviews.apache.org/r/33840/#comment133330> Why do we report "Views don't exist in this schema" if schema is not mutable? exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java <https://reviews.apache.org/r/33840/#comment133331> Will it better that we report different error for the case of "view not exists" (existingTable == null) and for the case of "there exists other type of entry with the identical name" (existingTable.getJdbcTableType() != Schema.TableType.VIEW) ? - Jinfeng Ni On May 5, 2015, 12:21 a.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33840/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 12:21 a.m.) > > > Review request for drill and Jinfeng Ni. > > > Repository: drill-git > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/DRILL-2423 for details. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java > 2428b45 > > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestBaseViewSupport.java > bfe113b > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java > 2ae6991 > > Diff: https://reviews.apache.org/r/33840/diff/ > > > Testing > ------- > > Added unittests > > > Thanks, > > Venki Korukanti > >
