-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33897/
-----------------------------------------------------------

Review request for drill and Jason Altekruse.


Bugs: DRILL-2602
    https://issues.apache.org/jira/browse/DRILL-2602


Repository: drill-git


Description
-------

updated both ExternalSortBatch and StreamAggBatch to throw a proper UNSUPPORTED 
user exception.
Here is the output when using a Stream aggregate:
```
Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support sorts 
with changing schemas

Fragment 0:0

[Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010]
```
And here is the error message for a hash aggregate:
```
Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support 
schema changes

Fragment 0:0

[Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010]
```


Diffs
-----

  common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 
4da4ee8 
  common/src/main/java/org/apache/drill/common/exceptions/UserException.java 
9283339 
  
common/src/test/java/org/apache/drill/common/exceptions/TestUserException.java 
a145f95 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
 b753574 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
 e88bc67 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java
 75892f9 

Diff: https://reviews.apache.org/r/33897/diff/


Testing
-------

all unit tests are passing along with functional/tpch100


Thanks,

abdelhakim deneche

Reply via email to