----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33834/#review82697 -----------------------------------------------------------
Ship it! Ship It! - Jason Altekruse On May 5, 2015, 1:14 a.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33834/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 1:14 a.m.) > > > Review request for drill and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > This patch simply cleans up redundant logic in ParquetToDrillTypeConverter > and refactors common logic to determine minor type in a function. > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/util/CoreDecimalUtility.java > 302652e > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetToDrillTypeConverter.java > 7c3eeb8 > > Diff: https://reviews.apache.org/r/33834/diff/ > > > Testing > ------- > > > Thanks, > > Mehant Baid > >
