----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33903/#review83005 -----------------------------------------------------------
One improvement for the unit test, but otherwise LGTM (non-binding). exec/java-exec/src/test/java/org/apache/drill/exec/work/fragment/TestFragmentExecutorCancel.java <https://reviews.apache.org/r/33903/#comment133883> To make sure you get the expected exception here, declare a boolean variable initialized to false before the try block. Then set it to true inside the catch block. After the catch block use assertTrue() on it. - Chris Westin On May 8, 2015, 9:12 a.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33903/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 9:12 a.m.) > > > Review request for drill, Chris Westin and Jacques Nadeau. > > > Bugs: DRILL-2878 > https://issues.apache.org/jira/browse/DRILL-2878 > > > Repository: drill-git > > > Description > ------- > > *INITIAL-PATCH* > > This is a "quick fix" that seem to solve the problem, at least for the cases > I am able to reproduce it for. closeOutResources() shouldn't throw any > exception at this point because we didn't even start running, and any > allocation failures will be suppressed (do we want this ?) > > If this fix is acceptable I will go ahead and add a "private volatile boolean > startedRunning" that will be set to true in run() and used in cancel() to > check if we need to call closeOutResources(). > > I will also add a unit test, I know how to reproduce the problem for both the > root and intermediate fragments, but I still need to find a proper way to > detect that those fragments were not closed properly. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > ddb828c > > exec/java-exec/src/test/java/org/apache/drill/exec/work/fragment/TestFragmentExecutorCancel.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33903/diff/ > > > Testing > ------- > > all unit tests are passing along with functional/tpch100 > > I will redo the tests once DRILL-2757 has been committed > > > Thanks, > > abdelhakim deneche > >
