----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34021/ -----------------------------------------------------------
Review request for drill and Aman Sinha. Repository: drill-git Description ------- Have broken down the final patch into two for easier review. This is a minor refactoring patch. This patch simply moves count aggregate function to a different template than existing aggregate functions. Reason being that count is the only aggregate function with a required output type (irrespective of the input type). This will eliminate some of the conditional logic in the templates. Diffs ----- exec/java-exec/src/main/codegen/config.fmpp 8db120d exec/java-exec/src/main/codegen/data/AggrTypes1.tdd 8952417 exec/java-exec/src/main/codegen/data/CountAggrTypes.tdd PRE-CREATION exec/java-exec/src/main/codegen/data/DecimalAggrTypes1.tdd 5ac299c exec/java-exec/src/main/codegen/templates/CountAggregateFunctions.java PRE-CREATION Diff: https://reviews.apache.org/r/34021/diff/ Testing ------- All unit tests and functional tests pass Thanks, Mehant Baid
