----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33910/#review83198 -----------------------------------------------------------
Ship it! LGTM - Parth Chandra On May 7, 2015, 5:42 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33910/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 5:42 a.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2961 > https://issues.apache.org/jira/browse/DRILL-2961 > > > Repository: drill-git > > > Description > ------- > > Preparation for query/network timeout methods: > - Moved class ...jdbc.DrillStatement to ...jdbc.impl.DrillStatementImpl. > - Created interface ...jdbc.DrillStatement interface, extending > java.sql.Statement (for place for Drill-specific narrowed declarations and > documentation). Declared DrillStatementImpl to implement new > DrillStatement. > - Updated references. > - Adjusted visibility (temporarily make somethings publich until DRILL-2089 is > done more). > > Misc. code hygiene: > - Purged extraneous imports of ResultSet. > - Purged TODO made obsolete by UserException. > - Misc. whitespace. > > > Diffs > ----- > > > exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java > 6e41bb4 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > c73eb50 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java > a4a97fd > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java 7fc79be > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java > adbbb64 > > exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java > 8d882e9 > exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java > a7e6d98 > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33910/diff/ > > > Testing > ------- > > Ran new specific unit tests. > > Ran existing tests. > > > Thanks, > > Daniel Barclay > >
