----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33911/#review83199 -----------------------------------------------------------
Ship it! LGTM - Parth Chandra On May 7, 2015, 5:42 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33911/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 5:42 a.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2961 > https://issues.apache.org/jira/browse/DRILL-2961 > > > Repository: drill-git > > > Description > ------- > > Changed implementation of Statement.setQueryTimeout(...) and > Connection.setNetworkTimeout(...) to throw SQLFeatureNotSupportedException > rather than silently not setting timeout. > > Main: > - Added implementations of Statement.{set,get}QueryTimeout(...) and > Connection.{set,get}NetworkTimeout(...) methods (in classes > DrillStatementImpl, DrillConnectionImpl). > - Added Drill-specific narrowed declarations and documentation (in > interfaces DrillStatement and DrillConnection). > - Added unit tests (in new StatementTest, ConnectionTest). > > Narrowed other thrown exceptions to allow narrowing in above methods: > - Narrowed exceptions on isClosed() and checkNotClosed() (in > DrillConnectionImpl, DrillStatementImpl). > - Added InvalidParameterSqlException. > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java 33acb42 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > c73eb50 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java a609bb1 > > exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidParameterSqlException.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java > PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java > PRE-CREATION > exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33911/diff/ > > > Testing > ------- > > Ran new specific unit tests. > > Ran existing tests. > > > Thanks, > > Daniel Barclay > >
